search

kappnav / issues

kAppNav global issues
0 stars 0 forks source link

Support for automatic application creation for Knative service #181

Closed navidsh closed 4 years ago

navidsh commented 4 years ago

Currently, kAppNav doesn't support automatic Application creation for Knative service based on the kAppNav documentation. It would be great if this scenario can be supported by adding auto-create labels to Knative Service resources.

cvignola commented 4 years ago

@navidsh The auto-create label is intended to be specified by the creator of the resource. Is there a reason why KNative resources would not be handled the same way?

navidsh commented 4 years ago

@cvignola If the user adds the kappnav.app.auto-create: true | false label to a Knative Service, would kAppNav automatically create an Application CR for it?

cvignola commented 4 years ago

@navidsh auto-create is presently supported for Deployment and Stateful set resource kinds only. What resource kind would need to support auto-create for the Knative use case?

navidsh commented 4 years ago

@cvignola Users would create a Knative Service (serving.knative.dev/Service) for deploying their applications through Knative e.g.

apiVersion: serving.knative.dev/v1
kind: Service
metadata:
  name: greeter
spec:
  template:
    spec:
      containers:
      - image: quay.io/rhdevelopers/knative-tutorial-greeter:quarkus
        livenessProbe:
          httpGet:
            path: /healthz
        readinessProbe:
          httpGet:
            path: /healthz

IMO, the Knative Service is the right place for adding auto-create labels.

Users can now pick Knative Service from within the Developer dashboard on OCP, it would be nice story to be able to auto-create Application CR by adding a proper kAppNav labels there. image

cvignola commented 4 years ago

Support is coming: https://github.com/kappnav/design/blob/master/part-of.md

cvignola commented 4 years ago

Enabled by this issue: https://github.com/kappnav/issues/issues/208