kapresoft / wow-addon-actionbar-plus

Action Bar Plus Addon for World of Warcraft
5 stars 1 forks source link

M6: Use M6 Macro Name instead of the Blizzard Macro Name #264

Closed nfet closed 1 year ago

nfet commented 1 year ago

Epic: #258

Bug

With the new ABP version, the example from the OP now shows the correct icon, but the labels are still missing:

WoWScrnShot_041723_181621

Also the tooltip does not show the label (it just shows the macro text from the stub, e.g. _M6+s07)

The label is constructed with #label <labeltext> in M6. See the screenshot in the first spoiler of the OP.

The labels are not super-hyper-important, but, as you can see in the example, they can be pretty helpful to identify the content of the macros. (In this case they set the posting quantity in Auctionator to a predefined number.)

Originally posted by @tflo in https://github.com/kapresoft/wow-addon-actionbar-plus/issues/256#issuecomment-1511712331

tflo commented 1 year ago

What is the content of this m6 macro?

It's still the same bar with Auctionator scripts from my original post. So, for example:

#icon 1505925
#label 192
/run AuctionatorSellingFrame.SaleItemFrame.Quantity:SetNumber(192)

BTW, the label text (on the button, not in the tooltip) is still (or again?) missing. Didn't we have the text in one of the previous versions?

nfet commented 1 year ago

OK, then that was the expected tooltip for now for non/spell/item types.

/run AuctionatorSellingFrame.SaleItemFrame.Quantity:SetNumber(192)

For this one: I never added the macro name text (or label) in the original ABP or the ABP-M6 addon because it convolutes the button (just my preference and it doesn't mean it's right for other players).

I can provide an option if this is needed. I can see how you might find this useful. There's not a lot of real estate in that button for texts anyways. Let me know.

BTW, the label text (on the button, not in the tooltip) is still (or again?) missing. Didn't we have the text in one of the previous versions?

tflo commented 1 year ago

For this one: I never added the macro name text (or label) in the original ABP or the ABP-M6 addon

OK, thanks. I am old and memory doesn't get better ;) (Actually, it was never really good...)

because it convolutes the button

Labels are usually short. That's one of the good things about M6, that it doesn't abuse the macro name as labels, like Blizz does. This also means that there is no text on the button if there is no label declaration in the macro. So it's completely up to the user how "convoluted" the button will be.

I can see how you might find this useful.

Just have a look at the screenshot in the topmost post here, and I think you'll also find labels on the button useful ;)

In this case I would even call them essential. As said, in other cases they are not super-hyper important, but still useful, yet alone because they tell me at a glance if the button is a macro or just an item/toy/spell.

Also in my more "normal" M6 macros, e.g. with spells and abilities, I use them to condense information into it. For example a label that contains "+t" means that the macro contains a /use 13 or /use 14 or both (Trinkets).