Conflict with EDB Prepare carefully - Githubissues

kaptain-kavern / CK_AnimalPlant_Pack

This mod alter the tropical rainforest biome : it add a significant amount of new animals and plants to the game and increase fauna and flora diversity.

https://ludeon.com/forums/index.php?topic=33296

6 stars 4 forks source link

Conflict with EDB Prepare carefully #28

Closed kaptain-kavern closed 8 years ago

kaptain-kavern commented 8 years ago

Reported by @tammabanana

From forum thread : https://ludeon.com/forums/index.php?topic=26265.msg275007#msg275007

kaptain-kavern commented 8 years ago

As I don't use PC mod at all, and never have; I can't say nothing more than : "I will investigate"

lpCoercion commented 8 years ago

I dont use EDB prepare, but I dont see why it would create an issue. I assume it is all done using C# and it takes place during game creation.

lpCoercion commented 8 years ago

any ideas on this? I will ask skully if he knows. I think hes the author

lpCoercion commented 8 years ago

I talked to skullywag (author of EDB) on discord. He said the following:

install both mods
in the options of the game turn on verbose logging
start the game and go to the animal screen in question
quit game and check logs under: rimworld(version)_data/output.log

He posted on the thread too.

lpCoercion commented 8 years ago

well its actually not skullywags mod, but he is still looking into it lol

kaptain-kavern commented 8 years ago

Yep that the process I intend to follow. (Debugging is always start by this steps ;-) )

In fact the original modder's name was EDB but he quit recently, letting his mods open to be maintained by others. There was a time you couldn't find a player that doesn't play with some of EDB's mods (quite a few have been integrated in the base game over the time).

Anyway I will look into it, I was just not finding it that "urgent" because of the workaround existing by using scenario feature

lpCoercion commented 8 years ago

ah ok. we could push it out with v1.3.1 if it is an easy fix. I may have found it after talking with skully?

<label>junglefowl</label>
    <race>CK_Junglefowl</race>
    <!--<labelMale>jungle peacock</labelMale>-->
    <labelFemale>jungle hen</labelFemale>

removing the comment and making this

<labelMale>junglefowl</labelMale>

may fix the issue?

lpCoercion commented 8 years ago

skully said that labels and gender have to be set for EDB. my other thought would be somewhere where the art placeholder animals were commented out?

kaptain-kavern commented 8 years ago

Here is the fix : https://github.com/kaptain-kavern/CK_AnimalPlant_Pack/commit/bf3b2e9e981871274dac3a9e50de541c697939ab

It was because of code I left about Toucan (The code was still there but not the texture - that's where the error came from). Now it can start without problems

lpCoercion commented 8 years ago

awesome :) I let the forum know