karad / lein_template_descjop

A Leiningen template(Clojure/ClojureScript Project) for Web based desktop application with Electron (atom-shell).
http://descjop.org
394 stars 16 forks source link

Provide configurability for Electron version #27

Closed billrobertson42 closed 7 years ago

billrobertson42 commented 7 years ago

It would be useful to be able to specify a specific version of Electron to target, perhaps via configuration settings in project.clj. This would allow developers to control this and get you out of the business of releasing updates whenever a new version of Electron is released.

karad commented 7 years ago

Thank you for your request. I think that descjop setting should be possible within project.clj, too. But now, You can change Electron version in Gruntfile.js.

module.exports = function(grunt) {

    grunt.initConfig({
        pkg: grunt.file.readJSON('package.json'),
        "download-electron": {
            version: "1.3.2", // Electron version 1.3.2 -> 1.3.3
            outputDir: "./electron", 
            rebuild: true
        }
    });

    grunt.loadNpmTasks('grunt-download-electron');

};

and run

for linux / mac

$ lein descjop-init

for windows

$ lein descjop-init-win
billrobertson42 commented 7 years ago

I think that's sufficient. Maybe the result of this ticket should just be adding that information to the README.

karad commented 7 years ago

Ok. I released version.0.7.1. Added information of updating electron version.