search

karafka / rdkafka-ruby

Modern and performant Kafka client library for Ruby based on librdkafka
https://karafka.io
Other
354 stars 120 forks source link

Remove Ruby 2.6 support #304

Closed mensfeld closed 1 year ago

mensfeld commented 1 year ago

Based on this statement:

We remove Ruby version from our CI builds if they become EOL.

We can remove Ruby 2.6 because it's EOL for more than a year now.

On top of that, this https://github.com/karafka/rdkafka-ruby/issues/199 cannot be fixed easily with 2.6 but the fix works out of the box for 2.7+

mensfeld commented 1 year ago

@thijsc if you are ok with this, I would backport the mentioned patch here and would drop 2.6. That way we can fix this leak easily via the WeakMap.

thijsc commented 1 year ago

Works for me!