search

karafka / rdkafka-ruby

Modern and performant Kafka client library for Ruby based on librdkafka
https://karafka.io
Other
345 stars 120 forks source link

Add `seek_by` method #462

Closed zinahia closed 2 months ago

zinahia commented 2 months ago

This is to enable using only the needed parameters and remove the need to provide or create a fake Rdkafka::Consumer::Message which is an implementation wrapper that should not be needed for the API of the clients when calling seek.

It is my humble opinion that providing this alternative can give a cleaner interface for the clients to use, however I'm happy to receive feedback or change it in case there is something I might be missing.

The specs I added are based on the existing specs of the seek method.

PS to the maintainers: Thanks for your work, this is a great library ❤️

mensfeld commented 2 months ago

Thanks. This change aligns well with the nature of the lib (low level) as it actually provides lower level API than the one already existing :)