search

karafka / waterdrop

Standalone Karafka library for producing Kafka messages
https://karafka.io
Other
258 stars 39 forks source link

Align error.occurred behaviour for sync and async errors #322

Closed mensfeld closed 1 year ago

mensfeld commented 1 year ago

It was brought to me that WaterDrop does not report the inline errors via error.occurred, and this should not be like this.

While we should not hide errors, the notification bus should intercept all, report, and re-raise. That way, we get a consistent behavior of the error pipeline, and we can still allow users to deal with inline errors.

This can potentially leading to double-reports if someone subscribes to all the errors of WaterDrop AND at the same time does error reporting outside of Karafka, but then they can select which of the places they want to ignore (or what errors)

Since it's a behaviour change, we should bump to 2.5.

mensfeld commented 1 year ago

@nijikon please comment with your opinion :pray: