search

karaggeorge / electron-builder-notarize

Notarize Electron applications using electron-builder
MIT License
80 stars 20 forks source link

no such file or directory, open 'builder-effective-config.yaml' #10

Closed ruudboon closed 4 years ago

ruudboon commented 4 years ago

I'm not totally sure if this is a bug or that I misconfigured something. Locally notarize runs fine but in github actions I'm experience an issue that results in a missing builder-effective-config.yaml. See the full log here: https://github.com/ruudboon/tally-blaster/runs/854966767?check_suite_focus=true#step:8:170

karaggeorge commented 4 years ago

Hmm, I'm not sure. I haven't used/seen the builder-effective-config.yaml before. If it's working locally, I'm not sure why it would break in CI. Maybe electron-builder does something differently when running in CI?

I'll have to look into it

ruudboon commented 4 years ago

Hmm ok. If you could have a quick look it would be great but don't spend too much time. Looks like it's something I messed up.

karaggeorge commented 4 years ago

I don't have the time to look into this right now, but for future reference for myself, or anyone else who wants to look into it, the file (and path) are generated here: https://github.com/electron-userland/electron-builder/blob/d5d21da12f5efaf02659ce8d32c48440f6cf91ff/packages/app-builder-lib/src/packager.ts#L354-L359

karaggeorge commented 4 years ago

Wait actually right there, in this line: https://github.com/electron-userland/electron-builder/blob/d5d21da12f5efaf02659ce8d32c48440f6cf91ff/packages/app-builder-lib/src/packager.ts#L358

It only generates the file if it's not in CI

ruudboon commented 4 years ago

Ahh thnx.Will dive into this. Closing this since it's not related to your work. Thnx again

karaggeorge commented 4 years ago

If you find a different area where the appId or the config in general is accessible during the build process let me know, and I can try to update

karaggeorge commented 4 years ago

@ruudboon would it help if in the meantime I added support for an env var alternative to appId? So at least you can provide it for GH actions?

ruudboon commented 4 years ago

@karaggeorge Yeah that would probably help! On the other hand there must be a reason behind this and I can do manual deployments in the meantime so don't put too much effort into this.

karaggeorge commented 4 years ago

@ruudboon https://github.com/ruudboon/tally-blaster/pull/11 😄 Let me know if that works