karaggeorge / electron-builder-notarize

Notarize Electron applications using electron-builder
MIT License
80 stars 20 forks source link

Add dotenv #15

Closed arvinxx closed 2 years ago

arvinxx commented 2 years ago

relative issue: #15

arvinxx commented 2 years ago

hello,is there any update to merge it?

Bug-Reaper commented 2 years ago

I can't merge you, but as a humble copy-pasta man 💁‍♂️ I applaud your efforts

andirsun commented 2 years ago

@karaggeorge dude, can you please merge this ?

andirsun commented 2 years ago

@arvinxx I am facing an error with this new PR

📦 Start notarizing com.webalys.streamline found at /Users/julianacaromoreno/actions-runner/_work/streamline-web/streamline-web/dist/mac-universal/Streamline.app
  ⨯ The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of Error  failedTask=build stackTrace=TypeError: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of Error
    at Object.writeFileSync (node:fs:2163:5)
    at module.exports (/Users/julianacaromoreno/actions-runner/_work/streamline-web/streamline-web/node_modules/electron-builder-notarize/index.js:99:6)

Its because this line of code

fs.writeFileSync('notarization-error.log', error);