karaggeorge / electron-builder-notarize

Notarize Electron applications using electron-builder
MIT License
80 stars 20 forks source link

If you run electron-builder from the vue-cli notarizing fails #6

Closed rathboma closed 4 years ago

rathboma commented 4 years ago

electron-builder-notarize looks for the appId in package.json/build/appId.

If you are running electron-builder via vue-cli-electron-builder, the configuration for the builder is instead stored in vue.config.js.

electron-builder-notarize should get the appId from electron-builder directly.

A workaround for now is to add the appId to build in package.json

oshell commented 4 years ago

this does not work anymore, since putting "build" into package.json is not allowed in newer versions of vue-cli-plugin-electron-builder

I am creating a pull request, which has a fallback for vue-cli-plugin-electron-builder and takes the appId from the created builder config yaml file

oshell commented 4 years ago

PR: https://github.com/karaggeorge/electron-builder-notarize/pull/8