Oshell issue 6 fix - Githubissues

karaggeorge / electron-builder-notarize

Notarize Electron applications using electron-builder

MIT License

80 stars 20 forks source link

Closed oshell closed 4 years ago

karaggeorge commented 4 years ago

@oshell would you be interested in finishing this? Making the changes listed above by @krzysztof-jelski ?

Just make sure yarn test passes before pushing and I can merge this

ruudboon commented 4 years ago

Any updates on this? If it's only implementing the suggestions of @krzysztof-jelski I won't mind taking over and dropping a pull with those changes.

karaggeorge commented 4 years ago

Hey @ruudboon ,

I think I'm just going to apply the needed changes locally and publish a release. I'll update here when it's ready and close this

ruudboon commented 4 years ago

@karaggeorge Awesome, thnx. Then I will close my fork ;) :D

karaggeorge commented 4 years ago

@ruudboon can you check #9