search

karaggeorge / kap-key-cast

Log keys pressed while recording
MIT License
20 stars 2 forks source link

Don't throw cancel error when stopping the recording #7

Open karaggeorge opened 3 years ago

karaggeorge commented 3 years ago

https://github.com/wulkano/Kap/issues/986

Sentry Issue: KAP-9ER

macOS version: Big Sur (11) Kap version: 3.3.2

Unhandled Promise Rejection

CancelError: Promise was canceled
    at PCancelable.cancel (/p-cancelable/index.js:99:17)
    at Object.didStopRecording (/kap-key-cast/index.js:54:17)
    at /Applications/Kap.app/Contents/Resources/app.asar/main/common/aperture.js:56:28
    at Array.map (<anonymous>)
    at callPlugins (/Applications/Kap.app/Contents/Resources/app.asar/main/common/aperture.js:53:66)
    at cleanup (/Applications/Kap.app/Contents/Resources/app.asar/main/common/aperture.js:74:9)
    at Tray.stopRecording (/Applications/Kap.app/Contents/Resources/app.asar/main/common/aperture.js:218:5)
antonijap commented 3 years ago

Is this gonna be fixed? The issue is still there

austriker27 commented 3 years ago

Can confirm issue exists on macOS 10.14.6 and Kap 3.3.2

samundra commented 3 years ago

Hi everyone,

Is there any workaround for this issue other than resetting everything?

karansapolia commented 3 years ago

Encountered this issue today. Seems like this has remained unresolved for some time now. @karaggeorge Let me know if it would help if I could work on this or a sub-part of it. Happy to help.