search

karaggeorge / macos-audio-devices

Get, set and configure the Audio Devices on macOS
MIT License
166 stars 17 forks source link

Added support for device muting #5

Closed apollon closed 3 years ago

apollon commented 4 years ago

Hey,

I really like your package and a way how you organized everything. Well done!

I searched thru all npm packages to find those who able to toggle mute for microphone on my Mac. No-one can do that so I decided to use you package as a code base.

Mu solution works well on my Mac with MacOs 10.15.2. I think it might me useful to have such functionality as well.

karaggeorge commented 4 years ago

Hey @apollon thank you for the PR. Would you mind formatting the code with 2 spaces like it was and updating the PR? As it stands right now it changed every line of Swift code (to 4 spaces vs 2) so it's really hard for me to review what actually changed

apollon commented 4 years ago

@karaggeorge - Done. You can check.

apollon commented 4 years ago

@sindresorhus, @karaggeorge - Hi Guys, I've fixed issues that you found. Could you take a look?

sindresorhus commented 4 years ago

@apollon Bump

benswinburne commented 3 years ago

Hi @apollon, I was just looking for this exact feature too so wondered if I might somehow help you in getting this over the finish line?

I'm not familiar with swift but if this hasn't been abandoned I'd be happy to try and work through completing this with someone.

TODO: need to think how to handle when hasInput && hasOutput

It seems that the above is the main outstanding item. Had you had any initial thoughts around this I could look into further?

apollon commented 3 years ago

@sindresorhus, @benswinburne - Sorry Guys, I didn't have a chance to finish my PR. Will try to do finish it this weekend 😆.

apollon commented 3 years ago

I have to integrate this feature from scratch because I've gotten a lot conflicts during merge 🙂. New PR #13.