karakanb / devo

A Chrome and Firefox extension that displays GitHub Trending, Hacker News, Product Hunt and Designer News on every new tab.
https://burakkarakan.com/devo/
MIT License
401 stars 46 forks source link

Change platform cards #19

Closed karakanb closed 5 years ago

karakanb commented 5 years ago

This PR introduces the request in #11 in a primitive way. Allowing various window sizes, dragging and dropping cards and making them flexible in terms of usage introduces a lot of complexity. I have looked around for some easy solutions but couldn't find any, therefore I decided to skip that approach.

Instead, I have introduced a new component called platform-card that renders individual platforms and contains a platform select menu that allows users to change the platform visible on each card. The default selection will stay as it is, but the toggles allow users to change the platform on the card. Here is an example view: image

And this is the night mode view: image

Also, this changes required me to introduce a semi-standardized interface for different platforms. I have created a settings.js file which contains various information about the platform, such as the title, color, night time colors etc., and the platform cards are initiated from these configuration. My aim in introducing this approach was to allow adding different platforms without caring about the display internals and stuff.

There are couple of things I am not happy with this implementation:

However, even though there are these issues, the changes seem alright to be released at this point. The more I keep the branch open, the more I find stuff to tweak, which delays releasing this. I'd like to finalize the implementation, merge it and release it as soon as possible.

karakanb commented 5 years ago

I am merging this and will release the new version to a few test users before going for general availability.