search

karakanb / devo

A Chrome and Firefox extension that displays GitHub Trending, Hacker News, Product Hunt and Designer News on every new tab.
https://burakkarakan.com/devo/
MIT License
401 stars 46 forks source link

Add a search box with duck duck go #28

Closed viktor-evdokimov closed 3 years ago

viktor-evdokimov commented 4 years ago

So that I can keep browser in full screen mode.

karakanb commented 4 years ago

Hi Viktor, thanks for working on this. Would you mind sharing the reasoning why do you think this is needed within the extension? I am not very familiar with using browsers in full-screen mode, therefore I have always been searching for something through the browser address bar, but apparently this is not applicable for you.

In case of having this as a feature, I am reluctant since I am trying to keep the extension as clean as possible with not many additional features, so I'd be willing to have this feature in the release only if we could put this behind a feature toggle through the settings. Would you like to work on something like that?

viktor-evdokimov commented 4 years ago

I think feature flag make sense! let me give it a shot

karakanb commented 4 years ago

Glad to hear, let me know if you need any hand. I think instead of building a custom UI we can leverage Options pages both Firefox and Chrome support, might help building this much faster and without any runtime code.

karakanb commented 3 years ago

Hi Viktor,

I have decided not to support this feature as of now, therefore I'll be closing this PR. Thanks for your contribution here.