search

karakanb / devo

A Chrome and Firefox extension that displays GitHub Trending, Hacker News, Product Hunt and Designer News on every new tab.
https://burakkarakan.com/devo/
MIT License
401 stars 46 forks source link

An option for opening links in new tabs #31

Open qykong opened 4 years ago

qykong commented 4 years ago

Hi, thanks for this add-on. I really enjoy it so far!

While browsering through devo, I noticed one missing piece for myself is the feature to open links in new tabs. This would allow one to keep the scrolling status of the add-on page after a peek to a link in new tab. Hopefully this sounds to be useful.

This should be easy to implement with just a target="_blank" attribute. The tricky part is where to put the switch for turning it on (maybe a small popup menu for placing all different configurations including the existing switch for night mode).

Let me know if this is something you are interested in and if possible I'm happy to contribute a PR :D

karakanb commented 4 years ago

Hi there, thanks for the feedback!

Devo allows having a quick overview of these platforms, so it is not really meant to be used as a page that users will browse, that's why I made the links to be opened up on the page instead of a new one. I think it is a nice feature to have, but I wouldn't like it to be the default behavior, so I'd accept it only if it is behind a feature toggle in a settings page. I mentioned this in #28, maybe Viktor is working on that, I don't know. If so, I think it'd be better if we wait for it to be implemented, or maybe you guys can collaborate on that. What do you think?

qykong commented 4 years ago

Hi, thanks for your reply.

This makes sense and I agree it should be just a feature toggle rather than the default. Let's wait for Viktor's PR then.

kyng-cytro commented 10 months ago

Hi, thanks for your reply.

This makes sense and I agree it should be just a feature toggle rather than the default. Let's wait for Viktor's PR then.

ctrl + click ? at least in chrome