search

karakanb / devo

A Chrome and Firefox extension that displays GitHub Trending, Hacker News, Product Hunt and Designer News on every new tab.
https://burakkarakan.com/devo/
MIT License
401 stars 46 forks source link

feat: add change background feature #35

Closed CVarisco closed 3 years ago

CVarisco commented 4 years ago

First thing first, thank you for your extension, is super useful 🎉

What is this?

This PR is referred to #33 and allow the user to set a background image

What has changed?

Add <background-selector> component capable of getting an image as input, save it in the localStorage as base64 and add as background-image attribute to <div class="background">.

If the background image already exists in the localStorage, it will be used as background at component's mount.

Screenshot

Screenshot 2020-06-25 at 16 35 20

Feel free to do not accept or to change it as you want.

ps: This is my first time with Vue.js 👶

karakanb commented 4 years ago

Hi Christian,

Thanks for the PR. I haven't had the chance to check the fork locally, I will do that, but the example looks very cool. There are some things that I didn't like about the implementation, such as referring to the existence of a class in the parent context from within the component, which seems to be something to improve, but I'll check it in more detail once I have the time.

CVarisco commented 4 years ago

@karakanb thanks!

as you wish, feel free to change it!

karakanb commented 3 years ago

Hi Christian,

Sorry for the late reply. For now, since there hasn't been much demand and this is not a feature I see as needed, I have decided to put this work on hold and close both the PR and the issue to show my intent. I have limited time for Devo, therefore I'd like to avoid maintaining features that I don't see needed as of now.

The work you did here may still prove valuable in case I decide to reconsider this functionality, but for now, I'll be closing the PR. Apologies for not merging your first contribution.