karakanb / devo

A Chrome and Firefox extension that displays GitHub Trending, Hacker News, Product Hunt and Designer News on every new tab.
https://burakkarakan.com/devo/
MIT License
401 stars 46 forks source link

Follow system theme feature #75

Closed TheEdoRan closed 2 years ago

TheEdoRan commented 2 years ago

First of all, I have to say that I really love this extension and can't live without it now. Now, talking about the "problem": I'd love to see a "follow system theme" auto-switch in the extension. I like to keep my OS (macOS) in automatic theme mode, and while many applications and websites auto-switch from light to dark mode (and viceversa), Devo keeps the previously selected option. It isn't a big deal, obviously, but it would be nice if we could have this new option implemented, maybe with a three way switch or a simple checkbox.

karakanb commented 2 years ago

hey, thanks for the comment. I believe we are respecting that when the theme is setup for the first time, but if the user toggles it then we pick the toggle as a default. Introducing yet another way of managing that might be tricky, given that we have no current way of having configuration for Devo in order to keep it simple. If you have ideas about where could it live, or if you'd like to prepare a PoC, I'd take a look at it. I'll keep this in mind as well in case I can think of a simple and elegant way.

TheEdoRan commented 2 years ago

Ok, thanks for the information. I'll try to work on it and make a PR in the next days, If I find the time, hopefully. Closing for now.