search

karakum-team / karakum

Converter of TypeScript declaration files to Kotlin declarations
Apache License 2.0
42 stars 2 forks source link

Empty library name in `@file:JsModule` #4

Closed shubhamsinghshubham777 closed 1 year ago

shubhamsinghshubham777 commented 1 year ago

In the current latest version of this tool, when I'm trying to follow the Basic Usage guide, I can observe that the generated file has an empty JsModule name:

Screenshot 2023-05-01 at 5 07 08 PM

If I remove the moduleNameMapper section from karakum.config.json, the JsModule name seems to be generated fine i.e. @file:JsModule("js-file-download/js-file-download") ✅

sgrishchenko commented 1 year ago

That is right, moduleNameMapper behavior was changed but I forgot to update the guide, I will fix it soon.

sgrishchenko commented 1 year ago

I tried to updated Basic Usage, could you check it works for you now?

sgrishchenko commented 1 year ago

Also I added examples with code from Basic Usage guide, it seem it works fine now.