karakun / OpenWebStart

Run Web Start based applications after the release of Java 11
https://openwebstart.com
Other
417 stars 48 forks source link

Version 1.10, resource properties missing #587

Closed bjorndarri closed 3 months ago

bjorndarri commented 3 months ago

Resource properties are not forwarded to the application since updating to 1.10.

Looks like all my applications are broken with this update, since they all have jdbc urls specified in the resource section.

I'm working with very simple jnlp files, here's an example:

<?xml version="1.0" encoding="utf-8"?>
<jnlp spec="1.0+" codebase="https://xxxxx.yyy/app/" href="application.jnlp">

  <information>
    <offline-allowed/>
  </information>

  <security>
    <all-permissions/>
  </security>

  <resources>
    <j2se version="11+"/>
    <jar href="application.jar"/>
    <property name="db.url" value="jdbc:oracle:thin:@xxxxx.yyyy.zz:1234:rrrr"/>
  </resources>

  <application-desc main-class="xx.xx.xx.ApplicationPanel"/>
</jnlp>

The system property db.url is no longer forwarded to the application. There's nothing in the log file, by the way.

I looked through recent commits and found an interesting line in this one: cce96c6

OwsJvmLauncher:250

env.put(ApplicationInstance.IGNORE_JNLP_RESOURCE_PROPERTIES, "true");

I haven't looked into this any further, but this line does look a bit suspect, given the problem I'm running into :-).

fleminra commented 3 months ago

+1

All of our Web Start applications that depend on JNLP-set properties are fatally broken in OWS 1.10.0.

1.9.1 works.

patrice0 commented 3 months ago

I've had the same problem.

sclassen commented 3 months ago

We found the source of the problem an plan on releasing a bugfix early next week

patrice0 commented 3 months ago

Thank you!

sclassen commented 3 months ago

Fixed with 1.10.1