karalabe / ssz

Opinionated 0-alloc SSZ codec for Go
https://github.com/ethereum/consensus-specs/blob/dev/ssz/simple-serialize.md
BSD 3-Clause "New" or "Revised" License
39 stars 7 forks source link

Property-based tests for BeaconBlockBody: Serialize-Deserialize-Serialize roundtrip. Randomized HashConcurrent. #22

Closed sbudella-gco closed 1 month ago

sbudella-gco commented 2 months ago

Test TestSSZRoundTripBeaconBodyDeneb fails due to: https://github.com/karalabe/ssz/issues/18

karalabe commented 1 month ago

Thanks, made a simpler test in https://github.com/karalabe/ssz/pull/26 to test the explicit nil slice issue. Whilst I cannot very explicitly state the original behaviour was invalid, it's better if the slice gets inited, so I went with the suggested approach.