search

karaluh / ScrobblerBrainz

A MusicBee plug-in to scrobble tracks to ListenBrainz
https://getmusicbee.com/addons/plugins/266/scrobblerbrainz/
GNU General Public License v3.0
23 stars 2 forks source link

Support submitting "playing now" #8

Closed phw closed 1 year ago

phw commented 3 years ago

It would be great if the plugin would also support submitting the "playing now" notification.

From the LB side this looks exactly like a single listen submission, but with listen_type of "playing_now" and no timestamp. See

https://listenbrainz.readthedocs.io/en/production/dev/json/#json-doc

karaluh commented 3 years ago

Yes, that shouldn't be too hard, putting on the TODO list. Thanks for the report!

Viktini commented 2 years ago

I've implemented this on a fork. I'm happy to submit a PR if all's good. https://github.com/Viktini/ScrobblerBrainz/commit/9a0d560714e62a188b1ba22aef8af40ab844cd9d

karaluh commented 2 years ago

Thanks! I'll try to look at it next week.

forenta commented 1 year ago

Would be nice if the next week would come one day.

Thanks anyway for your work :)

Viktini commented 1 year ago

@forenta: I've since moved to Quod Libet (used to run MusicBee in WINE), but I can help get this and the code for MBID tag grabbing merged if Karaluh wants it. Also get the JSON output updated to ListenBrainz's current spec :)

karaluh commented 1 year ago

Yeah, life got in the way :/ But if you submit the PR i promise to review it and release a new version.

Viktini commented 1 year ago

Same here with life. I'll make sure the JSON is updated (might as well update that while doing this) and I'll send a pull request with everything included (I also implemented #7 with TagLib#, which also got a new version bump, but I'll work on working with that later. I want to push the current working code I have now.)

karaluh commented 1 year ago

Great, thank you a lot for this! I plan to merge and release it this weekend.