search

karamaan / karamaan-opaleye

Other
11 stars 7 forks source link

Should Wire be renamed Column? #37

Open tomjaguarpaw opened 10 years ago

tomjaguarpaw commented 10 years ago

Column would be a clearer name. Alternatively we could use the abbreviations Col or C.

ocharles commented 10 years ago

:+1:, Wire is a far too technical term (it only has meaning if you know that you got here from studying wiring diagrams).

tomjaguarpaw commented 10 years ago

Furthermore, the library doesn't especially resemble the wiring diagrams paper anymore!

tomjaguarpaw commented 10 years ago

@ocharles: C, Col or Column?

ocharles commented 10 years ago

I prefer Column.

tomjaguarpaw commented 10 years ago

I'm tempted to say that Column will make type signatures very long. My preference is Col, but I will wait for others to chime in.

dbp commented 10 years ago

I think I'd prefer Column as well. It is longer, but I think it's clearer, and IMO clarity wins over length. If things are truly too long and repeated, well, we have type aliases for that :)

But if not Column, then definitely Col. C seems like a mistake! Okay to define an alias in your own code, but not something that should be in a library.

tomjaguarpaw commented 10 years ago

OK, I'm happy to discard the C option. If no one else comes out in favour of Col then I'll go with Column.

c-lewis commented 10 years ago

As Daniel said, if someone finds their type signatures are getting unwieldy, they can always create an alias.

On Wed, Jul 16, 2014 at 9:34 AM, tomjaguarpaw notifications@github.com wrote:

OK, I'm happy to discard the C option. If no one else comes out in favour of Col then I'll go with Column.

— Reply to this email directly or view it on GitHub https://github.com/karamaan/karamaan-opaleye/issues/37#issuecomment-49165603 .