search

karamaan / karamaan-opaleye

Other
11 stars 7 forks source link

Improve the set of re-exports #38

Open tomjaguarpaw opened 10 years ago

tomjaguarpaw commented 10 years ago

We have https://github.com/karamaan/karamaan-opaleye/blob/dev/Karamaan/Opaleye/Reexports.hs for re-exports but it does not contain a comprehensive collection of functionality. This should be improved.

dbp commented 10 years ago

It seems that at least one blocking issue on this is the Expr / Query distinction. Because plenty of identifiers exist with the same name (and same conceptual use) in both of those contexts. You mentioned before that Query is a less general version of Expr - is changing the Query code to use Expr (and eliminating the duplicate identifiers) a straightforward thing to do?

tomjaguarpaw commented 10 years ago

Most of the duplicate Query operators are already implemented in terms of Expr operators:

https://github.com/karamaan/karamaan-opaleye/blob/master/Karamaan/Opaleye/Operators2.hs

I'm just not sure if I want to force users to use toQueryArrDef all the time. What do you think? Perhaps we could export the Expr operators and anyone who wants to avoid having to convert explicitly can import Operators2 themselves.

bergmark commented 10 years ago

It seems to me that using the expr variants is more common so it sounds good.