search

karan / Projects

:page_with_curl: A list of practical projects that anyone can solve in any programming language.
https://twitter.com/karangoel
MIT License
44.66k stars 10.53k forks source link

Prime-factorization is wrong #19

Closed madsulrik closed 10 years ago

madsulrik commented 10 years ago

Your prime-factorization code give the wrong result. ex. number = 12

[2,3]

when i actually have to be:

[2,2,3]

You can check the version I have on my repository.

c1b3rh4ck commented 10 years ago

You're rigth,you can create a pull request to solve the problem,the other can fetch changes from origin.

madsulrik commented 10 years ago

Not a wild change. I have just created a pull request on that file. So it should work now!

karan commented 10 years ago

I actually just printed the unique primes. I've fixed the code, but not merged the pull request..