search

karan / Projects

:page_with_curl: A list of practical projects that anyone can solve in any programming language.
https://twitter.com/karangoel
MIT License
44.66k stars 10.53k forks source link

Made it one line simpler #7

Closed rsantos90 closed 10 years ago

Drhealsgood commented 10 years ago

Not to be a dick, but it's been requested that you don't make merge requests.

Otherwise, if we were all to follow suit, someone would have posted this one liner by now:

number    = lambda string: len([char for char in string if char in 'aeiou'])

I commented on the actual commit but then realised it would be more appropriate in the discussion section, sorry about that.

karan commented 10 years ago

Correct me if I'm wrong, but what this one-liner does is count total number of vowels, and not count of each vowel.

Drhealsgood commented 10 years ago

No, you're correct. My apologies.

karan commented 10 years ago

It's okay! :-)

And yes, I'm not accepting merge requests, but I'm ready to learn better and more pythonic ways of coding. Please do create more issues and line comments where you think I must improve.

rsantos90 commented 10 years ago

Sorry about the merging request, it was the first time I was trying to help around here.

On 24 July 2013 12:09, Karan Goel notifications@github.com wrote:

It's okay! :-)

And yes, I'm not accepting merge requests, but I'm ready to learn better and more pythonic ways of coding. Please do create more issues and line comments where you think I must improve.

— Reply to this email directly or view it on GitHubhttps://github.com/thekarangoel/Projects/pull/7#issuecomment-21477717 .[image: Web Bug from https://github.com/notifications/beacon/DMMsw1Ypq92SfrdQsRFYHhCXeEQj6ug-4VI-zbQzXKlUB1zcvlSOj5G5odCCGhi1.gif]

karan commented 10 years ago

Alright here we go: https://github.com/thekarangoel/Projects/blob/master/CONTRIBUTING.md

If you'd like to contribute, please follow the steps, and I'd be happy to merge the changes!