search

karan / atom-terminal

Atom package to open terminal on current file's directory with "ctrl-shift-t"
https://atom.io/packages/atom-terminal
MIT License
70 stars 30 forks source link

Package.getActivationCommands is deprecated. #48

Closed rubencaro closed 9 years ago

rubencaro commented 9 years ago

Use activationCommands instead of activationEvents in your package.json Commands should be grouped by selector as follows:

  "activationCommands": {
    "atom-workspace": ["foo:bar", "foo:baz"],
    "atom-text-editor": ["foo:quux"]
  }
Package.getActivationCommands (/usr/share/atom/resources/app.asar/src/package.js:810:9)
Package.hasActivationCommands (/usr/share/atom/resources/app.asar/src/package.js:735:20)
<unknown> (/usr/share/atom/resources/app.asar/src/package.js:189:24)
Package.measure (/usr/share/atom/resources/app.asar/src/package.js:167:15)

Created from atom 0.198.0

tkw1536 commented 9 years ago

The exact same as #45. Please do not post double issues.

ghost commented 9 years ago

I fixed all deprecations in #41 (to be merged)