karancode / kustomize-github-action

:european_castle: Github action for kustomize
https://github.com/marketplace/actions/kustomize-github-action
MIT License
44 stars 28 forks source link

Add page iterator for future-proofing downloads #29

Closed phanama closed 3 years ago

phanama commented 3 years ago

Details of Change

Use page iterator to fetch releases from github api to future-proof downloads.

Issue

At the time of writing, page 2 of the release has 55 items already (55% to page 3):

$ curl -s https://api.github.com/repos/kubernetes-sigs/kustomize/releases?per_page=100&page=2 | jq '. | length'
55

Test Results

Small test of the block:

$ bash test.sh 1.0.1
getting download url for kustomize 1.0.1...
page 1
page 2
Download URL found in https://github.com/kubernetes-sigs/kustomize/releases/download/v1.0.1/kustomize_1.0.1_linux_amd64

$ bash test.sh 3.6.1
getting download url for kustomize 3.6.1...
page 1
page 2
Download URL found in https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize/v3.6.1/kustomize_v3.6.1_linux_amd64.tar.gz

$ bash test.sh 4.0.1
getting download url for kustomize 4.0.1...
page 1
Download URL found in https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize/v4.0.1/kustomize_v4.0.1_linux_amd64.tar.gz