For Commentary modules, the document Delete option is greyed out!

karandepratham / and-bible

Automatically exported from code.google.com/p/and-bible

0 stars 0 forks source link

For Commentary modules, the document Delete option is greyed out! #142

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

Having just installed the GerRieger commentary, I found that And Bible was 
unable to delete it, because the Delete option was greyed out!

And Bible 1.6.0 in Android 4.0

Original issue reported on code.google.com by DFH...@gmail.com on 9 Dec 2012 at 3:09

GoogleCodeExporter commented 8 years ago

The Delete option is not greyed out for Bible modules.

Original comment by DFH...@gmail.com on 9 Dec 2012 at 3:09

GoogleCodeExporter commented 8 years ago

[deleted comment]

GoogleCodeExporter commented 8 years ago

Hmmmm!  Just found out that it's only greyed out because I only had one 
commentary installed. When another is installed, and selected, the first one 
can be deleted.

Yet it still seems impossible to remove the last commentary though.

Please advise.

Original comment by DFH...@gmail.com on 9 Dec 2012 at 8:45

GoogleCodeExporter commented 8 years ago

When first writing the code, initially just for bible modules, I prevented 
deletion of the current Bible module to prevent possible crashes, as it is 
linked to in various places and ways.  This requirement also ensures that there 
is always at least one bible module - also preventing crashes.  It seemed 
natural to extend the 'not current' requirement to the other module types too.

Original comment by mjden...@gmail.com on 10 Dec 2012 at 10:12

Added labels: Type-Other
Removed labels: Type-Defect

GoogleCodeExporter commented 8 years ago

As it was, I only installed the Rieger in order to comment on the related issue.

IMHO, there should be an option to remove all module types except Bibles.

But I'll defer to your better judgement, as the issue is less serious than I 
first perceived.

I can always resort to deleting the DTN commentary manually (by means of the 
file manager), which is what I'd installed to follow up my first reporting of 
this issue.

Original comment by DFH...@gmail.com on 10 Dec 2012 at 10:25

GoogleCodeExporter commented 8 years ago

I think the original issue is now resolved.  Also there is pending work in 
JSword (DM) to allow deletion of modules immediately after download.  I may 
also alter AB to allow deletion of modules currently being viewed which may 
possibly ease some peoples confusion.

Original comment by mjden...@gmail.com on 15 Mar 2014 at 9:38

Changed state: Done