Open GoogleCodeExporter opened 9 years ago
Thanks for the code! Just some minor issues here - can you make it
follow the PEP 8 style guide, no camelCase and indent by four spaces? - I think
it's the Google's standard to use two-spaces indent but I wouldn't want to
introduce it here. Also, you're using conditional expressions new in Python 2.5
(value = 'true' if value else 'false') which means breaking the current solrpy
promise to work correctly with Python 2.3+. Other than that, the code looks
fine, although it would certainly be better if you could also create the test
cases
as someone will need to do it anyway..
Original comment by ds...@gefira.pl
on 18 Sep 2008 at 5:28
Sure thing, I'll get the changes done as soon as I can.
Original comment by bubble...@gmail.com
on 19 Sep 2008 at 9:22
OK, I've been away from this project for quite a while but I'm back on the
case. Your
suggestions have been implemented and unit tests have been modified / added. The
attached patch is against r28
Original comment by bubble...@gmail.com
on 12 Feb 2009 at 1:01
Attachments:
Unfortunately this patch doesn't apply to trunk anymore. Is there any chance
you'd be
willing to resubmit. Sorry for the delay :-(
Original comment by ed.summers
on 4 Feb 2010 at 11:53
Original issue reported on code.google.com by
bubble...@gmail.com
on 18 Sep 2008 at 3:14Attachments: