karaoke-dev / karaoke

Will be the best karaoke system.
http://blog.karaoke.dev
GNU General Public License v3.0
207 stars 16 forks source link

Implement karaoke skin manager. #1069

Open andy840119 opened 2 years ago

andy840119 commented 2 years ago

It's the temp way for developing karaoke skin.

What's should be done with this manager:

andy840119 commented 2 years ago

also might be better if check:

[update] see how BeatmapManagerWorkingBeatmap works. It just create LegacyBeatmapSkin instance.

andy840119 commented 2 years ago

Also, see how SkinManager and SkinModelManager works.

SkinManager is focused on providing skin, and SkinModelManager is for import / saving and deleting the skin.

andy840119 commented 2 years ago

And see how RulesetSkinProvidingContainer provides skin. Maybe override CreateLegacySkinProvider in KaraokeRuleset can use tricky ways to provide the skin .