karaoke-dev / karaoke

Will be the best karaoke system.
http://blog.karaoke.dev
GNU General Public License v3.0
206 stars 16 forks source link

Make lyric check manager individual or combined into lyric provider? #1258

Open andy840119 opened 2 years ago

andy840119 commented 2 years ago

It's need to discuss after #1239 implement. If we want's to update the invalid issue every time when create, update or delete, it might be better to be merged. But not really sure will it be ok if only update issue table when user see the issue table, or even only update if click the refresh button.

andy840119 commented 2 years ago

For the better performance, should only check the lyric that being updated. But we already have invalid state in every lyric row, means it should be update in every change.