karaoke-dev / karaoke

Will be the best karaoke system.
http://blog.karaoke.dev
GNU General Public License v3.0
198 stars 15 forks source link

Introduce : sub-singer #141

Open andy840119 opened 3 years ago

andy840119 commented 3 years ago

This is used to present singing status, like singing with echo, background or yelling.

Should be like :

In editor, mapper can select singer or status, e.g : can select Singer 1 or background(Belongs to singer 1).

And alert user not to create singing state like normal or main.

Singer object already means that.

.

Notice :

This status not means you can mix multi singer with single status.

If you wants multi singer to sing single lyric. you should select like : Singer 1 + Singer 2 or Singer 1 + background(belongs to singer 2) or background(Singer 1) + background(Singer2)

But mapper cannot select like Singer 1 + background(Singer 1) or background(Singer 1) + yelling(Singer 1)

.

Will be implemented if i had enough time.

andy840119 commented 3 years ago

Also note what propertysinger and sub-singer will have :

Singer :

Sub-singer :

.

And notice that max singer is 10 now, sub-singer is not limited right now.

andy840119 commented 3 years ago

Also should design a page to show which singer sing which lyric? Or place it into lyric maker?

andy840119 commented 3 years ago

Also, should create auto-fill to fill the singer info created in database.

Need to create list of singer in database

andy840119 commented 3 years ago

Will wait until most of design in editor has been implemented.

andy840119 commented 3 years ago

Also should notice some mapper set singer as animate or virtual character. But others might set as real singer. . Need to deal with that also.

andy840119 commented 3 years ago

SubSinger Will be the parent of Singer Like

List<SubSinger> SubSingers {get;set;}

in Singer.cs?

andy840119 commented 3 years ago

Model has been implemented. Remain singer editor.

andy840119 commented 3 years ago

Also should limit max singer number(include sub singer) to 30. Singer : 10 SubSinger : 30 Because int.max is 2,147,483,647, which very close to 2^30(1,073,741,824)

andy840119 commented 3 years ago

And should re-calculate ids if singer has been deleted.

andy840119 commented 3 years ago

Related feature will wait until this ruleset has fully implemented.

andy840119 commented 3 years ago

moved into V2