karaoke-dev / karaoke

Will be the best karaoke system.
http://blog.karaoke.dev
GNU General Public License v3.0
205 stars 16 forks source link

Create enum for let user easier to decide the sync property? #1542

Open andy840119 opened 2 years ago

andy840119 commented 2 years ago

https://github.com/karaoke-dev/karaoke/blob/9bd684779b55772858abcf9f324eacaa9cdea80b/osu.Game.Rulesets.Karaoke/Objects/Properties/SyncLyricConfig.cs#L11-L55 Maybe should be better to change the property into enum?

Part of issue #1444 Inspired from thinking about #1541

The benefit:

Need to think more:

andy840119 commented 2 years ago

Maybe: SyncLyricProperty:

SyncNoteProperty:

SyncLyricConfig: