karaoke-dev / karaoke

Will be the best karaoke system.
http://blog.karaoke.dev
GNU General Public License v3.0
198 stars 15 forks source link

Refactor singe matadata. #1769

Open andy840119 opened 1 year ago

andy840119 commented 1 year ago

Wnat's should be done in this issue:

And notice that did not make unnecessary things for sub-singer because not really sure will implement this or not. Might not be that useful i guess.

andy840119 commented 1 year ago

Damn, will have those issues:

andy840119 commented 1 year ago

Not very sure about last part because it should be possible to get the singer instance by working beatmap 🤔

andy840119 commented 1 year ago

Maybe change to the array and use the validator to check if singer instance is being synced or not

andy840119 commented 1 year ago

Maybe should make the validator more global? Reference lyric and singer listance will check by the flag