Move the stage info out of the karaoke beatmap.

karaoke-dev / karaoke

Will be the best karaoke system.

http://blog.karaoke.dev

GNU General Public License v3.0

207 stars 16 forks source link

Open andy840119 opened 1 year ago

andy840119 commented 1 year ago

I think finally the stage will be separated. And will use the injection (e.g. IStageProvider) to get and edit the stage.

Will use the Workingbeatmp.GetStream() to read the stage file.

andy840119 commented 1 year ago

Need to make sure that working beatmap is able to save the file.

andy840119 commented 1 year ago

Also, we need something like StageChangeHandler to undo/redo the stage.

andy840119 commented 1 year ago

I think will start implement this after:

It's too early for thinking about this.

andy840119 commented 1 year ago

Pin this issue for not forgot it.

andy840119 commented 1 year ago

Also, should think about:

[ ] how to trigger the drawable hit-object to re-calculate the working stage(maybe trigger by the change handler or in the stage)? -> maybe use working beatmap to load the stage info from the json file and put into the karaoke beatmap? Not very well but it's a workable way.