search

karaoke-dev / karaoke

Will be the best karaoke system.
http://blog.karaoke.dev
GNU General Public License v3.0
206 stars 16 forks source link

Lyric start/end time should be nullable. #2221

Closed andy840119 closed 7 months ago

andy840119 commented 7 months ago

What's done in this PR:

  1. Lyric start/end time property should be nullable.
  2. Warp lyric start/end time into single property. naming like LyricStartTime/LyricEndTime might be confused with StartTime/EndTime in the HitObject.