search

karaoke-dev / karaoke

Will be the best karaoke system.
http://blog.karaoke.dev
GNU General Public License v3.0
198 stars 16 forks source link

Make the stage using commands structure to affect the lyric property. #2244

Open andy840119 opened 1 month ago

andy840119 commented 1 month ago

Idea from the https://github.com/ppy/osu/pull/27539/files It can make adjust lyric effect/position/easing more simple.

andy840119 commented 1 month ago

What's should be done:

  1. Remove the StageEffectApplier and PlayfieldStageApplier
  2. Copy and create some customized commands from the Storyboards/Commands
  3. Stage should be able to generate the commands for lyric/playfield.
  4. DrawableLyric/Playfield should be able to execute the commands.
andy840119 commented 3 weeks ago

Maybe wait until storybook editor in the lazer implemented? Because not very sure IStoryboardCommand or StoryboardCommandGroup will be serializable?