Font selection improvement

karaoke-dev / karaoke

Will be the best karaoke system.

http://blog.karaoke.dev

GNU General Public License v3.0

207 stars 16 forks source link

Closed andy840119 closed 1 month ago

andy840119 commented 3 years ago

Now it's able to change the font without any conversion 🥳 The next step is UI improvement.

The conversion will include:

[ ] Check why ruby/romaji cannot apply the customized font.
[x] Should mark font extension at the end of the font (if the font is not internal)
[ ] [optional] Should load font list only if user opens the select font dialog.
[ ] [optional] should limit max font number in the dictionary (for the case if user load too many fonts)

andy840119 commented 3 years ago

Also:

[x] should have the ability to hot-reload the font list if the dictionary is changed in the font selector.
[x] should be able to open the dictionary on the config page.
[x] should create a folder at default. Need to check should do this job in FontManager or another place.
[ ] [optional]should be able to hide internal fonts.

andy840119 commented 3 years ago

About font missing issue. I guess it's about getting the wrong base height(getTextHeight) in PositionTextBuilder

baseHeight.HasValue should be less then 1 but got no idea why got 13 in customized font.

andy840119 commented 1 month ago

Font selection is useable state. Also, it's already able to mark the font type.