karaoke-dev / karaoke

Will be the best karaoke system.
http://blog.karaoke.dev
GNU General Public License v3.0
205 stars 16 forks source link

Re-write get config in karaoke skin bindable. #982

Open andy840119 opened 2 years ago

andy840119 commented 2 years ago

After #927 has been implemented, it's time to refactor this part.

What's need to be concern(or can be thinking):

andy840119 commented 2 years ago

https://miro.com/app/board/uXjVOZkakKw=/?invite_link_id=352441695809 Wait until all spec done in miro.

andy840119 commented 2 years ago

image Damn it looks like a piece of shit.

andy840119 commented 2 years ago

image Another version. Now looks like a turkey shit I guess. Not that bad as previous version.

andy840119 commented 2 years ago

And should notice that:

andy840119 commented 2 years ago

image Guess it might be the final version.

andy840119 commented 2 years ago

[NOTE] another question:

andy840119 commented 2 years ago

should use lots of bindables

pros:

cons:

call skin.sourcechange

pros:

cons

conlusion