search

karasevm / PrivateDNSAndroid

Quick settings tile to switch active private DNS server
MIT License
420 stars 47 forks source link

Option to edit the server #29

Closed stephenvaz closed 3 months ago

stephenvaz commented 3 months ago

Hi, I (a user of PrivateDNSAndroid) recently updated from version 1.3 to 1.7, wherein the labels were implemented. I immediately wanted to edit my servers but on tapping them I was only presented with an option to delete the server.

Obviously, a user can delete and re-create the entry with a label, but I thought that having an option to edit is much easier.

I have modified the AddServerDialogFragment mainly to also act as the editable dialog when clicked upon and have also added the Delete button which opens the delete dialog.

I primarily work with Flutter and am relatively new to Native Android Development. This is my first contribution so let me know if I could've done any better.

https://github.com/user-attachments/assets/4269e394-c834-41a6-bf94-dda2c60f9a51

stephenvaz commented 3 months ago

@karasevm Also added a TextView when the items are empty image

karasevm commented 3 months ago

Looks good to me, thanks for your contribution