search

karasevm / PrivateDNSAndroid

Quick settings tile to switch active private DNS server
MIT License
420 stars 47 forks source link

Add Text field Validation #9

Closed InfiniteCoder06 closed 5 months ago

InfiniteCoder06 commented 7 months ago

Resolves #6

karasevm commented 7 months ago

Generally not a big deal but I don't like how this implementation is more restrictive than the system settings one (source code). I feel at the very least IDN's like яндекс.рф and 互联网中心.中国 should be accepted. As an alternative maybe just fail the validation if any special character are matched?

InfiniteCoder06 commented 7 months ago

Generally not a big deal but I don't like how this implementation is more restrictive than the system settings one (source code). I feel at the very least IDN's like яндекс.рф and 互联网中心.中国 should be accepted

Adding the package of Google guava Library to get the same implementation

Adding this library doesnt affect the output size since R8 is enabled

karasevm commented 5 months ago

LGTM