search

karashiiro / TextToTalk

Chat TTS plugin for Dalamud. Has support for triggers/exclusions, several TTS providers, and more!
MIT License
46 stars 30 forks source link

Add ability to boost volume to 200% for Polly #115

Closed ryankhart closed 2 years ago

ryankhart commented 2 years ago

Also formatted the number in the UI to look like a percent. I tried this for the System voice backend, and the game crashed, but it seems fine for Amazon Polly backend.

I had been having this issue where the text-to-speech voice volume was so much quieter than not only the game sound but the rest of my Windows volume of other apps. I worked around this by setting my game volume to 30% to make it not completely overpower the volume of text-to-speech, and that worked, but when I am alt-tabbing in and out of the game frequently, I often found myself having to constantly adjust my Windows system or speaker volume because it was so loud coming from the game where I had my volume high to hear the quiet TTS to my browser tabs watching YouTube where the volume frequently startled me from being so loud.

This might not be the most elegant solution what I have committed here, but it seemed the simplest to implement this way, and I also didn't want to keep the max at 100% and then double it after the volume variable was saved because people updating from an older version of TextToTalk would then get blasted with double the volume unexpectedly.

ryankhart commented 2 years ago

I forgot to switch back to the main branch before pushing commits to the lexicon. I'm not entirely sure what the best way to handle this mistake is. I'll experiment and give an update when I figure something out. This is going to test the limits of my current git knowledge.

ryankhart commented 2 years ago

Wait wha? It looks like I accidentally merged this branch myself when I did that comment. That big green button was just a little too enticing for me, I guess.

ryankhart commented 2 years ago

Ok I think I fixed it. I reverted my C# change on main, checked out my new feature branch again, cherry picked the commit I had intended for this pull request, and I have opened up a new pull request here: https://github.com/karashiiro/TextToTalk/pull/116