search

karashiiro / TextToTalk

Chat TTS plugin for Dalamud. Has support for triggers/exclusions, several TTS providers, and more!
MIT License
46 stars 30 forks source link

UX issue with Lexicon repository - Make "Enable for Backends" enabled by default for both backends #119

Open ryankhart opened 2 years ago

ryankhart commented 2 years ago

I got a friend into FFXIV and introduced him to TextToTalk, and he's been loving it. When I was chatting him about the lexicon repository feature though, we both seemed to miss the fact that, when you install a lexicon from the repository, both backend options are disabled by default. So, installing does nothing until you enable them for the backend that you are using.

Could we change the default for that setting to true when the user installs a new lexicon? I haven't encountered any issues enabling them all blindly, but I concede that it might be a useful feature to have around in case we need to troubleshoot.

image

karashiiro commented 2 years ago

If it seems to work, we can flip it to be enabled by default, but we've had issues with IPA symbols that aren't supported on the System backend before, haven't we?

johnysandels commented 2 years ago

I'm pretty sure that all of the ipa character bugs we've found so far have been fixed in the code to allow for the same entries to work in both Polly and system backends

ryankhart commented 2 years ago

Ah so that's also why we ended up with 2 lexicons that ended up being identical, one for System and one for Amazon Polly. As of now, we don't have any lexicons in the repository that work for one and not the other anymore, as far as I can tell.

ryankhart commented 2 years ago

I suppose we could wait a little while longer while my...informant...has some more time spend on the System voice backend to give more feedback on how our IPAs are handling on System. I'm not super motivated downgrade from Amazon Polly to do extensive testing except for one-offs.