karashiiro / TextToTalk

Chat TTS plugin for Dalamud. Has support for triggers/exclusions, several TTS providers, and more!
MIT License
45 stars 30 forks source link

♪ symbol causing problems #197

Open johnysandels opened 3 months ago

johnysandels commented 3 months ago

I have repeated issues with punctuation being read aloud whenever it is followed by a music note symbol: ( ♪ ).

This happens whenever a character is singing, such as The Wandering Minstrel, Jehantel (from the Bard questline), and even Tataru when she is humming a tune.

So what I have gotten is:

  1. .♪ : When a verse ends with a period ( . ) directly before a music note symbol ( .♪ ) It reads "(any lyrical line) dot"
  2. ~♪ : When a verse ends with a tilde ( ~ ) directly before a music note symbol ( ~♪ ) It reads "(any lyrical line) tilde"
  3. ,♪ : When a verse ends with a comma ( , ) directly before a music note symbol ( ,♪) It reads it as "(any lyrical line) comma"
  4. -♪ : When a verse ends with a dash ( - ) directly before a music note symbol ( -♪ ) It reads it as "(any lyrical line) dash"

I think these are the four most common occurrences in which the music note causes the punctuation or other symbol to be read aloud, but there may be more. What I cannot figure out, yet, is how to silence those punctuations from being verbalized when directly followed by a music note symbol without any spaces, as generally the ♪ always comes after punctuation without any spaces.

It can be quite annoying, especially when the song or ditty has multiple lines to it.

Originally posted by @SaphiraGrace in https://github.com/karashiiro/TextToTalk/discussions/62#discussioncomment-8868244

johnysandels commented 3 months ago

I imagine this should be a simple fix by just ignoring this symbol when parsing text

SaphiraGrace commented 3 months ago

That's what I thought too but I'm not entirely sure how to write that in a lexicon to be ignored. I'm still a little new to this

johnysandels commented 3 months ago

It's just an issue with how the plugin reads text, the dev should be able to fix it

SaphiraGrace commented 3 months ago

Oh, thanks! Cool! I will wait for a solution. Has been a thing as long as I can remember, probably was something that just never got adjusted yet.