search

karashiiro / TextToTalk

Chat TTS plugin for Dalamud. Has support for triggers/exclusions, several TTS providers, and more!
MIT License
48 stars 28 forks source link

Fix openai api key not being saved #218

Closed PassiveModding closed 3 months ago

PassiveModding commented 4 months ago

https://github.com/karashiiro/TextToTalk/issues/210

Previously the openai api key would never be saved since it's value was being retrieved from the client.ApiKey property each draw

oops

Theletha commented 4 months ago

when will this fix be implemented?

johnysandels commented 4 months ago

It may be awhile, the dev @karashiiro hasn't updated anything recently so I assume they're busy with life stuff.

karashiiro commented 4 months ago

I was getting things working for 7.0, then doing MSQ, then Universalis being down took a week of my attention, and now I'm on vacation until Tuesday - I'm planning to catch up on TTT issues once I'm back.

Theletha commented 4 months ago

i See! Have a good vacation !

andrewgxp commented 3 months ago

I built the plugin using the new changes proposed in the PR and was able to save my login key!

For some reason, it won't let me copy and paste the API key into the text box. Maybe OpenAI keys are too large for it? I've not been able to get it to functionally work because of that, but I can confirm that it looks to now save whatever I'm putting in!

xianthe commented 3 months ago

I built the plugin using the new changes proposed in the PR and was able to save my login key!

For some reason, it won't let me copy and paste the API key into the text box. Maybe OpenAI keys are too large for it? I've not been able to get it to functionally work because of that, but I can confirm that it looks to now save whatever I'm putting in!

Definitely please find out a way to copy the API key.

xianthe commented 3 months ago

I did some checking - it seems the API key has a character limit for cut and paste that is not large enough for the 132-character OpenAI key.

karashiiro commented 3 months ago

Merging, will fix the length limit myself.