search

karashiiro / TextToTalk

Chat TTS plugin for Dalamud. Has support for triggers/exclusions, several TTS providers, and more!
MIT License
47 stars 30 forks source link

1.8.0.1 Bugs #36

Closed johnysandels closed 3 years ago

johnysandels commented 3 years ago

-Deleting plugin in plugin installer runs into an error installer error

karashiiro commented 3 years ago

Can you be more specific on the /echo thing? I thought I was able to replicate this, but it turned out that the Echo chat type was just disabled.

karashiiro commented 3 years ago

Also, can you provide an error from the log for the deleting the plugin?

johnysandels commented 3 years ago

Yeah definitely!

dalamud.log

karashiiro commented 3 years ago

That one's fixed, will merge with https://github.com/goatcorp/DalamudPlugins/pull/971, no clue on the /echo issue yet, though.

johnysandels commented 3 years ago

Just checked echo, I turned it on and the first messages worked and all messages after didn't work.

karashiiro commented 3 years ago

Might be related to #37? If so we should revisit this one after 1.8.0.2 is merged.

johnysandels commented 3 years ago

This is with my lexicons disabled. It might have something to do with #35 and the queue order. I can load it up tonight to see if it's fixed.

karashiiro commented 3 years ago

My PR is still open, so I'll just drop this here in case you happen to have time for it 🙂

latest.zip

johnysandels commented 3 years ago

Deleting the plugin is fixed, echo is fixed. text queueing is working at expected.

chat text triggered between dialogue boxes uses the gendered voice of the dialogue speaker.

When disabling the plugin by toggle, chat speech was stopped, and the first dialogue speech was stopped, but the second dialogue box read out.

Also your revert to reset the speaker mentioned in #35, is either not part of this update, or I was not able to make it work.

karashiiro commented 3 years ago

The speaker reset works for me, but I'll look into it further just in case. The other issues seem to be caused by the system backend not always responding to speech cancellation requests - the Polly backend doesn't seem to have these issues. Looking into that right now.

johnysandels commented 3 years ago

For me it resets once the final dialogue box is closed, but doesn't reset between dialogue boxes.

karashiiro commented 3 years ago

For me it's the exact opposite 😄 I think that it's really just a result of how much time is being spent between dialogue advances, though.

karashiiro commented 3 years ago

I think I finally have a fix, will drop a link in a minute.

karashiiro commented 3 years ago

latest.zip

Here's the new build I'm PRing, let me know how it works 👍

johnysandels commented 3 years ago

I've just checked all of those bugs, and it seems like everything is working! Beautiful work!