Closed karashiiro closed 2 years ago
I might be able to take a swing at this one if you haven't already started working on it. I get a little excited about text manipulation projects.
I don't feel confident enough to push to master though, so if I push a change, I'll branch first, and then let you merge if it's good, @karashiiro.
Sounds good, have at it 👍
I just learned a lot about how to build plugins, got more familiar with the TextToTalk codebase, and got the configuration part for this feature committed here, but I have yet to start on the text manipulation to parse the first name from the last name.
Also, since FFXIV refers to them as "forename" and "surname" and because "first name" and "last name" are just western cultural terms, I took the liberty to call them "forename" and "surname" in the UI. However, I kept "First" and "Last" in the code because it made for shorter variable names.
Below is a gif of the configuration UI. I'm open to feedback on it. It does nothing currently, but that'll come in a future commit.
Got a pull request ready for this now. https://github.com/karashiiro/TextToTalk/pull/88
I feel so empowered now. That was my first successful coding contribution to an existing project on GitHub.
Merged, I'll haul it on the lexicon repo and make a testing release with all of the new changes soon.
Also just noticed: you must have been burning the midnight oil on this one 👀
Released in testing version 1.13.0.
Also just noticed: you must have been burning the midnight oil on this one 👀
Technically yes, but I just have a late sleep schedule this past week.
Released in stable v1.13, closing.
Discussed in https://github.com/karashiiro/TextToTalk/discussions/85