karashiiro / TextToTalk

Chat TTS plugin for Dalamud. Has support for triggers/exclusions, several TTS providers, and more!
MIT License
46 stars 30 forks source link

NullReferenceException causes game crash to desktop if user logs into Amazon Polly while TTS is in progress #98

Closed ryankhart closed 2 years ago

ryankhart commented 2 years ago

I got a a NullReferenceException crash to desktop twice in a row when I was listening to an NPC speak. I realized that it wasn't the Amazon Polly voices that I expected, so while listening, I opened up the TTT config, went to Synthesizer tab->Voices, and I clicked "Save and Login". That crashed with this message in the screenshot on both times.

image

I was able to reproduce this same crash in one other way as well by switching from Amazon Polly while logged to the System "Voice backend" while the TTS was in progress.

I tried it again several times by switching the following while a TTS was in progress:

None of these last 3 test cases could reproduce the crash.

karashiiro commented 2 years ago

Possibly fixed in v1.13.1

ryankhart commented 2 years ago

It's fixed for me. I can't get the game to crash again following my repro steps specified above. I'll close this issue for now. If it crops back up, I'll reopen it later.