search

karask / python-bitcoin-utils

Library to interact with the Bitcoin network. Ideal for low-level learning and experimenting.
MIT License
271 stars 102 forks source link

feat: add operator __eq__ for script.Script #61

Closed PabloLION closed 7 months ago

PabloLION commented 7 months ago

Hi @karask , This is my PR for #60. I didn't find contribution guide or dev setup. I also checked other PRs, and it seems there's no CICD actions to check either. So I just put this code here. Could you check it for me? Thanks.

karask commented 7 months ago

Hi @PabloLION ,

There is no contribution guide yet. I mean to add one but it is always delayed. Do you know/recommend any good guide maybe from other projects that you have worked with?

One thing I would add to the PR (and should be in the guide) is to a test for the new feature. Maybe, create a test_scripts.py in tests to add it. If not, I can add it myself later.

Let me know and thanks for the contribution.

karask commented 7 months ago

Hi @PabloLION , just merged.

PabloLION commented 7 months ago

🙏🏻thanks